Add and expose Basis/Transform2D/3D division by float operator #86364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
approved these changes
Dec 20, 2023
|
We should probably consider doing the same for |
aaronfranke
force-pushed
the
basis-divide
branch
from
c9cb1ce to
c77ae05
Compare
aaronfranke
changed the title
|
Updated to add for Transform2D and Transform3D as well. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a situation where I needed to use
basis * (1.0 / number)to inversely scale a basis uniformly, but it would've been nicer to have a division operator. This PR adds that operator. The code is almost identical to the*operator.