Fix UndoRedo history mismatch when creating a new tile atlas
#86387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
approved these changes
Dec 21, 2023
There was a problem hiding this comment.
This is a correct fix.
The issue is basically the same as #79750. It only happens with TileSet saved to file. Undo history starts in global context, but the newly created atlas is recognized as a built-in resource, thus part of the scene, causing mismatch.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #86291
It seems that there's no need to put
set_texture_region_sizein do method as it's a newly created resource and no pairded redo method.But I feel the
history mismatchproblem lies in other places, it's only a stopgap measure. Any suggestions ?