Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Clang -Winconsistent-missing-override warning #86392

Merged

Conversation

bitsawer
Copy link
Member

Adds missing override and final qualifiers to VulkanContextWindows::_get_platform_surface_extension(), similar to other VulkanContext implementations. Missing these causes a build error when building with dev_mode enabled (warnings as errors):

In file included from platform\windows\godot_windows.cpp:31:
In file included from platform\windows/os_windows.h:53:
platform\windows/vulkan_context_win.h:42:22: error: '_get_platform_surface_extension' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
        virtual const char *_get_platform_surface_extension() const;
                            ^
./drivers/vulkan/vulkan_context.h:261:22: note: overridden virtual function is here
        virtual const char *_get_platform_surface_extension() const { return nullptr; }
                            ^
1 error generated.

@bitsawer bitsawer added this to the 4.3 milestone Dec 21, 2023
@bitsawer bitsawer requested a review from a team as a code owner December 21, 2023 12:13
@clayjohn clayjohn requested a review from a team January 6, 2024 02:28
@akien-mga akien-mga changed the title Fix Clang dev_mode build on Windows Fix Clang -Winconsistent-missing-override warning Jan 11, 2024
@akien-mga akien-mga merged commit a86a285 into godotengine:master Jan 11, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants