C#: Upgrade TFM for net472 and some netstandard2.0 projects
#86454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulsntos
reviewed
Dec 22, 2023
modules/mono/editor/GodotTools/GodotTools.OpenVisualStudio/GodotTools.OpenVisualStudio.csproj
Show resolved
Hide resolved
modules/mono/editor/GodotTools/GodotTools.OpenVisualStudio/Program.cs
Outdated
Show resolved
Hide resolved
modules/mono/editor/GodotTools/GodotTools.IdeMessaging/GodotTools.IdeMessaging.csproj
Outdated
Show resolved
Hide resolved
modules/mono/editor/GodotTools/GodotTools.BuildLogger/GodotTools.BuildLogger.csproj
Show resolved
Hide resolved
Repiteo
force-pushed
the
c#-upgrade-TFMs
branch
2 times, most recently
from
0cbf833
to
7fc02f9
Compare
Repiteo
force-pushed
the
c#-upgrade-TFMs
branch
from
7fc02f9
to
7a06390
Compare
raulsntos
approved these changes
Jan 9, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by raulsntos's post here, this PR upgrades a handful of
.csprojfiles to targetnet6.0as their framework. 3 were able to be upgraded by tweaking the project file, while one needed a minor file refactor. They all build successfully, but I'm unsure of how to do a more thorough test for possible regressions beyond what's already setup in the build system checks