Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only update particle velocity when it changes #86474

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Only update particle velocity when it changes #86474

merged 1 commit into from
Jan 8, 2024

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Dec 23, 2023

Fixes #86401

@KoBeWi KoBeWi added bug regression performance topic:particles cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Dec 23, 2023
@KoBeWi KoBeWi added this to the 4.3 milestone Dec 23, 2023
@KoBeWi KoBeWi requested review from a team as code owners December 23, 2023 17:05
clayjohn
clayjohn approved these changes Jan 6, 2024
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Most functions that push data to the rendering server will implicitly call redraw_request() This one is no exception

@akien-mga akien-mga merged commit 97607b6 into godotengine:master Jan 8, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the particular_velocity branch January 8, 2024 11:16
@YuriSizov YuriSizov removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Jan 25, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.2.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
bug performance regression topic:particles
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

GPUParticles2D cause editor redrawing even when not visible
4 participants
@KoBeWi @akien-mga @YuriSizov @clayjohn