Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix D&D viewport position calculation #86511

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

Sauermann
Copy link
Contributor

It is necessary to transform screen position to viewport position.
resolve #86493

It is necessary to transform screen position to viewport position.
@Sauermann Sauermann added this to the 4.3 milestone Dec 25, 2023
@Sauermann Sauermann requested a review from a team as a code owner December 25, 2023 22:35
@Sauermann Sauermann added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Dec 25, 2023
Copy link
Member

@RandomShaper RandomShaper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@akien-mga akien-mga merged commit 60b2096 into godotengine:master Jan 2, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@Sauermann Sauermann deleted the fix-drag-transform branch January 2, 2024 23:12
@YuriSizov YuriSizov removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Jan 25, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.2.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can_drop_data with embedded subwindows disabled ignores viewport content_scale_factor
4 participants