Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Path2D editing #86542

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Dec 27, 2023

When adding or splitting a point in Path2D, it was creating 2 undo actions: for creating the point and moving it. This PR merges it into one undo action.

godot.windows.editor.dev.x86_64_R0WNbJugn5.mp4

@ajreckof
Copy link
Member

ajreckof commented Jan 4, 2024

I'm wondering if this is also needed for Path3D

@KoBeWi
Copy link
Member Author

KoBeWi commented Jan 4, 2024

I tested Path3D and it didn't seem to have this problem.

Copy link
Member

@ajreckof ajreckof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works perfectly. Except for the small issue I pointed above this looks really good.

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Jan 5, 2024
@akien-mga akien-mga merged commit 53d47a3 into godotengine:master Jan 8, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants