Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cubic_interpolate_in_time_variant() to Animation #86601

Merged

Conversation

TokageItLab
Copy link
Member

@TokageItLab TokageItLab commented Dec 29, 2023

Fixes #85066.

However, about the string interpolation, it fallbacks to linear interpolation because cubic interpolation could not be applied neatly.

@TokageItLab TokageItLab added this to the 4.3 milestone Dec 29, 2023
@TokageItLab TokageItLab requested a review from a team December 29, 2023 09:13
@TokageItLab TokageItLab force-pushed the add-cubic-interpolation-variant branch 5 times, most recently from f1e4e63 to d06fa9f Compare December 29, 2023 11:43
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Read through the code. Did not run through the test cases.

@TokageItLab TokageItLab force-pushed the add-cubic-interpolation-variant branch from d06fa9f to e538ce3 Compare December 30, 2023 04:30
@akien-mga akien-mga merged commit 2f8005c into godotengine:master Jan 2, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@TokageItLab TokageItLab deleted the add-cubic-interpolation-variant branch February 14, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cubic interpolation doesn't work with some of the Variant types
3 participants