-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some options to Project Settings to silence warnings in AnimationMixer caching #86608
Add some options to Project Settings to silence warnings in AnimationMixer caching #86608
Conversation
c95f058
to
05a9f54
Compare
05a9f54
to
e9aa879
Compare
e9aa879
to
6936732
Compare
6936732
to
07b7a14
Compare
@KoBeWi Can you send an MRP? I assume the error is the problem somewhere else where the setting not affected (maybe AnimationTrackEditor?). |
599f52c
to
bb3b178
Compare
Spam is probably exaggerated, there is just a single error print when clicking the AnimationPlayer. |
bb3b178
to
1b7ef45
Compare
@KoBeWi The null checks in AnimationTrackEditor were missing in some places, so I fixed them. Errors have gone. The KeyType determination in ValueTrack fails when the node cannot be found with path, but I assume it seems to be expected behavior. |
1b7ef45
to
a1107f2
Compare
2c63ec6
to
56ecd6b
Compare
Oops, sorry I accidentally closed it while cleaning up an old branch. |
56ecd6b
to
dc4b7bc
Compare
Changed some lines to adopt #88247. |
Thanks! |
This PR is a salvaged version of #69480 with corrected error handling for finding path as pointed out in #85368. Also, as discussed several times in the past, invalid paths will be changed to a warning instead of an error since it is not a critical.
However, since cases where animations do not play due to path mismatches may occur to a certain extent in beginners, so the default is true; There are cases where the destination of add_child scenes is wrong, the name of the Skeleton is changed due to the use of retargeting and etc. It means, flag have been inverted from the original PR (#69480).
And finally, I added a statement in the warning that it is possible to turn off that warning in project settings.
throw_error_with_invalid_path
to Project Setting and remove cache error fromAnimationTree
#69480