Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect VehicleWheel3D Roll Influence description #86672

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

qwofford
Copy link
Contributor

@qwofford qwofford commented Dec 31, 2023

Updated VehicleWheel3D Roll influence description and confirmed the tooltip has been updated in the Editor Inspection window.

I updated the es.po translation file, but additional translations need to be corrected. I updated english text for fr.po, zh_CN.po and zh_TW.po in this PR, but I need to find someone to update the alternative text for each of these files.

This PR fixes #85805.

@qwofford qwofford requested a review from a team as a code owner December 31, 2023 20:18
@AThousandShips
Copy link
Member

AThousandShips commented Dec 31, 2023

The translations are still present, you still need to remove them as instructed, all of the changes, no changes should be done to the translations like this, and please squash your commits into one 🙂, see here

@AThousandShips AThousandShips added this to the 4.x milestone Dec 31, 2023
@AThousandShips AThousandShips added cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Dec 31, 2023
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than those changes this looks good, based on indications from testing by people on the issue report and statements there this should be correct

@AThousandShips AThousandShips modified the milestones: 4.x, 4.3 Dec 31, 2023
@qwofford
Copy link
Contributor Author

Do I understand correctly that you want me to remove all translation changes from this pull request, such that the impacted lines in *.po remain as they are on master right now?

What is the appropriate approach to update translations?

@qwofford qwofford marked this pull request as draft December 31, 2023 21:20
@AThousandShips
Copy link
Member

AThousandShips commented Dec 31, 2023

Yes, indeed, the updates to the translation are done on the webplate, see here

@qwofford qwofford force-pushed the qwofford/issue85805 branch from 292d172 to c979d02 Compare December 31, 2023 22:11
@qwofford qwofford marked this pull request as ready for review December 31, 2023 22:11
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, as per above

Please squash your commits into one, see here

@AThousandShips AThousandShips requested a review from a team January 1, 2024 09:56
@akien-mga akien-mga changed the title Fix for incorrect VehicleWheel3D Roll Influence description in tooltip and documentation Fix incorrect VehicleWheel3D Roll Influence description Jan 2, 2024
@akien-mga akien-mga merged commit b4b96ab into godotengine:master Jan 2, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@YuriSizov YuriSizov removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Jan 24, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.2.2.

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jan 24, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VehicleWheel3D wheel_roll_influence documentation is wrong
4 participants