-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect VehicleWheel3D Roll Influence description #86672
Conversation
The translations are still present, you still need to remove them as instructed, all of the changes, no changes should be done to the translations like this, and please squash your commits into one 🙂, see here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than those changes this looks good, based on indications from testing by people on the issue report and statements there this should be correct
Do I understand correctly that you want me to remove all translation changes from this pull request, such that the impacted lines in What is the appropriate approach to update translations? |
Yes, indeed, the updates to the translation are done on the webplate, see here |
292d172
to
c979d02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, as per above
Please squash your commits into one, see here
Thanks! And congrats for your first merged Godot contribution 🎉 |
Cherry-picked for 4.2.2. |
Cherry-picked for 4.1.4. |
Updated VehicleWheel3D Roll influence description and confirmed the tooltip has been updated in the Editor Inspection window.
I updated the
es.po
translation file, but additional translations need to be corrected. I updated english text forfr.po
,zh_CN.po
andzh_TW.po
in this PR, but I need to find someone to update the alternative text for each of these files.This PR fixes #85805.