Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle built-in shaders when closing scene #86710

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Handle built-in shaders when closing scene #86710

merged 1 commit into from
Jan 2, 2024

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Jan 2, 2024

Resolves TODO in the shader editor. When closing scene, the editor will warn about unsaved shaders. This is relevant after #75864

Also fixed the unsaved shader list displaying wrong names.

@KoBeWi KoBeWi added this to the 4.3 milestone Jan 2, 2024
@KoBeWi KoBeWi requested a review from a team as a code owner January 2, 2024 15:02
akien-mga
akien-mga approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@akien-mga akien-mga merged commit 2158f88 into godotengine:master Jan 2, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the do_not_the_shaders branch January 2, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug enhancement topic:editor topic:shaders
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@KoBeWi @akien-mga