Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autocompletion for AnimationLibrary & AnimationMixer's methods #86799

Merged

Conversation

Mickeon
Copy link
Contributor

@Mickeon Mickeon commented Jan 4, 2024

Complements #86754

image

This PR autocompletes the AnimationLibrary methods with the names of every existing animation, if they can be detected. Admittedly, this is fairly niche.
But, AnimationMixer's methods are much less so.

@Mickeon Mickeon force-pushed the autocompletion-animationlibrary branch from 2b5d061 to 787f61d Compare January 4, 2024 20:11
@Mickeon Mickeon requested a review from a team as a code owner January 4, 2024 20:11
@Mickeon Mickeon changed the title Add autocompletion for AnimationLibrary's methods Add autocompletion for AnimationLibrary & AnimationMixer's methods Jan 4, 2024
@YeldhamDev YeldhamDev added this to the 4.3 milestone Jan 4, 2024
@fire fire requested a review from a team January 4, 2024 23:47
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving this from the usability perspective that it is a good change for bettering quality of life.

@akien-mga akien-mga merged commit 62616fb into godotengine:master Jan 5, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants