Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ui_cancel to unselect all nodes in all edit modes in 2D, matching 3D behavior #86805

Conversation

ryevdokimov
Copy link
Contributor

Supplementary to #86804, but not dependent.

I couldn't find a reason why this shouldn't be the case as this is the behavior in 3D.

@ryevdokimov ryevdokimov changed the title Allow ui_cancel to unselect all nodes in 2D, matching 3D behavior Allow ui_cancel to unselect all nodes in all edit modes in 2D, matching 3D behavior Jan 4, 2024
@akien-mga akien-mga requested a review from a team January 5, 2024 07:48
@akien-mga akien-mga added this to the 4.x milestone Jan 5, 2024
Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supplementary to #86804, but not dependent.

When you press Escape to clear selection, there is no way to select back without switching tool. That could've been the reason behind original condition.

@ryevdokimov
Copy link
Contributor Author

Supplementary to #86804, but not dependent.

When you press Escape to clear selection, there is no way to select back without switching tool. That could've been the reason behind original condition.

Ah, so supplementary and dependent would have been more accurate. 😅

Kind of odd that this is the behavior in 3D then, I must have just been desensitized to it.

Both PRs should unify the behavior of 2D and 3D and allow for a less janky workflow then IMO.

@akien-mga akien-mga changed the title Allow ui_cancel to unselect all nodes in all edit modes in 2D, matching 3D behavior Allow ui_cancel to unselect all nodes in all edit modes in 2D, matching 3D behavior Jan 8, 2024
@akien-mga akien-mga modified the milestones: 4.x, 4.3 Jan 8, 2024
@akien-mga akien-mga merged commit 4aa8e87 into godotengine:master Jan 8, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@ryevdokimov ryevdokimov deleted the clear-nodes-on-ui-cancel-2d branch January 8, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants