Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various typos in documentation #86820

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Conversation

sepTN
Copy link
Contributor

@sepTN sepTN commented Jan 5, 2024

No description provided.

@sepTN sepTN requested a review from a team as a code owner January 5, 2024 08:48
@akien-mga akien-mga added this to the 4.3 milestone Jan 5, 2024
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Did you use a tool to find those?

Could be worth adding those to codespell's dictionary, as it's the main tool we run on the whole codebase. This would prevent re-introducing the same typos in other places.
https://github.com/codespell-project/codespell#sending-pull-requests

Edit: Likewise for your previous batch: #86549

@sepTN
Copy link
Contributor Author

sepTN commented Jan 5, 2024

Looks good! Did you use a tool to find those?

I only use "Code Spell Checker" extension in my VSCode, and manually skim through lines that are getting color highlighted. I haven't looked into codespell, I'll check it out during one of these weekends 😆

@akien-mga akien-mga merged commit 89cc635 into godotengine:master Jan 5, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@AThousandShips AThousandShips added cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Jan 23, 2024
@YuriSizov YuriSizov removed cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Jan 24, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.2.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants