Add documentation to JavaClass & JavaClassWrapper #86839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mickeon
force-pushed
the
java-class-documentation
branch
from
f31585a to
26a9b3e
Compare
Mickeon
force-pushed
the
java-class-documentation
branch
from
26a9b3e to
b9551c1
Compare
RedMser
reviewed
Jan 5, 2024
Mickeon
force-pushed
the
java-class-documentation
branch
from
b9551c1 to
1310dd0
Compare
mhilbrunner
approved these changes
Apr 7, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #22136.
I... seriously don't know. I am struggling to understand the meaning of them. Any mention of these is outstandingly lacking, as if hidden in ancient scrolls. The code is old, uncommented and a bit garbled, and the history on GitHub doesn't tell me anything. Even the Android devs aren't exactly sure what these are for: JNISingleton exists and the tutorial for it is sufficient, at least.
Ever since their introduction they've been left ignored lacking any sort of documentation or proper tutorial. What's the purpose of these? Their obscurity stood out to me like a sore thumb. I had to know, and fill them with some semblance of information. Hence, I have written my... best guesses.