Change AudioStreamPlayer autoplay and GLTFBufferView getters to be const #86907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronfranke
force-pushed
the
getter-const
branch
from
e350272 to
b98823a
Compare
aaronfranke
force-pushed
the
getter-const
branch
2 times, most recently
from
185ee35 to
0ab5677
Compare
aaronfranke
force-pushed
the
getter-const
branch
from
0ab5677 to
d6dc7ec
Compare
aaronfranke
force-pushed
the
getter-const
branch
from
d6dc7ec to
9940f8d
Compare
aaronfranke
force-pushed
the
getter-const
branch
from
9940f8d to
35c99bb
Compare
fire
approved these changes
Feb 9, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to use these functions with
const AudioStreamPlayer *p_etc parameters, but I found that these methods were not marked as const, so I could not use them. This PR fixes this and adds compatibility methods.