Fix virtual calls for GDExtension in CollisionObject2D
#86908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nter, _mouse_exit, _mouse_shape_enter, _mouse_shape_exit
rburing
approved these changes
Jan 7, 2024
|
Thanks for the PR! This looks good to me. |
akien-mga
added
the
cherrypick:4.2
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
|
Cherry-picked for 4.2.2. |
akien-mga
removed
the
cherrypick:4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this is my first PR for Godot engine,
if I am doing something wrong please kindly point me in the right direction.
This fix is similar in nature to #85870
Same bug, same fix but 2D instead of 3D respectively. I will comment on the issue of that bug since its so similar and link the PR there.
Hopefully that is in line with the way you usually handle a case like this arround here, if you have a diffferent process with making a separate bug report first, let me know!