Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C#: Fix return type hint for methods. #86972

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

zaevi
Copy link
Contributor

@zaevi zaevi commented Jan 8, 2024

As #86256 (comment) mentioned, the bridge didn't pass return-type info for methods to CSharpScript before.

Will completely close #86256.

Minimal reproduction:
csharp_type_test.zip

@zaevi zaevi requested a review from a team as a code owner January 8, 2024 20:46
@raulsntos raulsntos added this to the 4.3 milestone Jan 9, 2024
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@akien-mga akien-mga merged commit cea5633 into godotengine:master Jan 10, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 4.2.2.

@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't call C# static function
3 participants