Add documentation to EditorExportPlatformWeb #86977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mickeon
force-pushed
the
documentation-editor-export-platform-web-no-funny-quirks-in-this-branch
branch
3 times, most recently
from
65f1070
to
4e38071
Compare
AThousandShips
added
cherrypick:4.1
Calinou
reviewed
Feb 11, 2024
Calinou
reviewed
Feb 11, 2024
Calinou
reviewed
Feb 11, 2024
Calinou
reviewed
Feb 11, 2024
Calinou
reviewed
Feb 11, 2024
Mickeon
force-pushed
the
documentation-editor-export-platform-web-no-funny-quirks-in-this-branch
branch
from
4e38071
to
7ffacb5
Compare
|
Addressed all of the above feedback. |
|
Thanks! |
Mickeon
deleted the
documentation-editor-export-platform-web-no-funny-quirks-in-this-branch
branch
|
Cherry-picked for 4.2.2. |
akien-mga
removed
cherrypick:4.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fills in the class reference of EditorExportPlatformWeb. Yeah.
This also has the side-effect of displaying them when hovering over the settings in the Export window, which is really, really good:
Would be nice to get some feedback on factual correctness, sooner than later.
Sidenote, isn't it funny that html/experimental_virtual_keyboard has been "experimental" for 2 years? What a funny setting name.