Add missing descriptions for Image's documentation #86997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
added
enhancement
documentation
cherrypick:4.1
AThousandShips
approved these changes
Jan 9, 2024
akien-mga
reviewed
Jan 9, 2024
Mickeon
force-pushed
the
documentation-image
branch
from
b3923a3
to
4b82dba
Compare
BlueCube3310
suggested changes
Jan 9, 2024
clayjohn
reviewed
Jan 9, 2024
clayjohn
reviewed
Jan 9, 2024
Mickeon
force-pushed
the
documentation-image
branch
from
4b82dba
to
e01b917
Compare
|
Pushed changes to address the above feedback. Thank you both for providing suggestions! |
|
Thanks! |
YuriSizov
removed
the
cherrypick:4.2
|
Cherry-picked for 4.2.2. |
YuriSizov
removed
the
cherrypick:4.1
|
Cherry-picked for 4.1.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds missing descriptions to Image's methods and constants, filling them in.
The only ones I have doubts about are FORMAT_ETC2_RA_AS_RG and FORMAT_DXT5_RA_AS_RG, and code is not exactly clear unless you're savvy enough.
...
Uhm... Yeah, that's all.