Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give EXR saving methods a default value of false like the bindings #87062

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Give EXR saving methods a default value of false like the bindings #87062

merged 1 commit into from
Jan 11, 2024

Conversation

aaronfranke
Copy link
Member

The bindings already had a default value of false, but this was missing internally:

ClassDB::bind_method(D_METHOD("save_exr", "path", "grayscale"), &Image::save_exr, DEFVAL(false));
ClassDB::bind_method(D_METHOD("save_exr_to_buffer", "grayscale"), &Image::save_exr_to_buffer, DEFVAL(false));

@aaronfranke aaronfranke added this to the 4.3 milestone Jan 10, 2024
@aaronfranke aaronfranke requested a review from a team as a code owner January 10, 2024 21:57
@akien-mga akien-mga merged commit ed0be57 into godotengine:master Jan 11, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@aaronfranke aaronfranke deleted the exr-grayscale-false branch January 11, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fire fire fire approved these changes

Assignees
No one assigned
Labels
enhancement topic:core
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@aaronfranke @akien-mga @fire