Switch between global and local transforms when top level is toggled in a Node3D #87100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required, but does not fully fix: #86861 due to how AABBs bounds are calculated.
Currently when you toggle top level, the transform values remain relative to the origin of the parent. This PR fixes this and will now toggle between global and local transforms.
The code that has been modified has been in Godot since the beginning, and I can't think of any reason why it's needed now. I'm assuming this is an artifact of some work around to something that existed a decade ago, and since 3D has been majorly reworked is no longer required.
2024-01-12.01-09-26.mp4