[MP] Handle cleanup of "scene cache" nodes #87190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is also a candidate for cherry pick, but it might be better to test it a bit more in 4.3 devs |
Calinou
added
the
cherrypick:4.2
Faless
force-pushed
the
mp/fix_cache_cleanup
branch
from
3630121 to
98c203f
Compare
YuriSizov
reviewed
Jan 18, 2024
YuriSizov
reviewed
Jan 18, 2024
YuriSizov
approved these changes
Jan 18, 2024
Faless
force-pushed
the
mp/fix_cache_cleanup
branch
from
98c203f to
7bab409
Compare
Make sure we delete the relevant ObjectID from the cache when the nodes are removed from tree.
Faless
force-pushed
the
mp/fix_cache_cleanup
branch
from
7bab409 to
853df28
Compare
|
Thanks! |
YuriSizov
removed
the
cherrypick:4.2
|
Cherry-picked for 4.2.2. |
Cherry-picked reverted for 4.2.3 as it introduced a regression (fixed in 4.3 by a partial revert #94984). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure we delete the relevant ObjectID from the cache when the nodes are removed from tree.