Add bone update option to OpenXRHand to allow preserving original hand scale #87240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would rename 'All' to 'Full' and 'Rotation' to 'Rotation only'. |
…d scale. This is useful if the hand model is not weighted to support re-scaling to the users hands; or the hand is scaled to non-human sizes.
Malcolmnixon
force-pushed
the
bone-update-mode
branch
from
db06886 to
c316eee
Compare
Done |
akien-mga
changed the title
dsnopek
approved these changes
Jan 16, 2024
m4gr3d
approved these changes
Jan 16, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds an option to OpenXRHand to select the type of bone updates to perform.
The supported options are:
The Rotation mode is useful if the hand model is not weighted to support re-scaling to the users hands; or the hand is scaled to non-human sizes.
With "Full" the following hand model gets damaged (the fingers get pushed into the palm):
Switching to "Rotation Only" preserves the bone lengths - and the mesh integrity:
