Fix renaming a node to the name of its siblings breaking NodePath #87252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix cases where node name was not visually updated because name was not changed Co-Authored-By: Nông Văn Tình <53887662+nongvantinh@users.noreply.github.com>
KoBeWi
approved these changes
Jan 22, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rebase and updated version of #76575
Fix #76192
I also fix another issue where there was cases where node name was not visually updated because name was changed to an invalid node name which was automatically changed to a valid one which happens to be the previous name of the node which cancels renaming.
This issue was already present with invalid character and this PR added the same for renaming to the name of a sibling.