-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add color in built-in documentation for overridden properties #87255
Add color in built-in documentation for overridden properties #87255
Conversation
eaf83c4
to
5444c37
Compare
The test failed because the generated class reference would need to be updated to move the overridden properties above all else. In my opinion, the sorting of this PR does makes sense, but that's a lot of multiple, small changes that would need to be done, and I'm not sure if this PR is desired just yet as is. |
I think this should only be on the display side, unless they're put in a separate tag I don't think we should do complicated sorting like this, you should be able to iterate over them twice when displaying, slightly unnecessary processing but the most trivial method IMO |
Yeah, I agree with this. This change shouldn't require precise ordering in the XML files. It should just be a visual enhancement. |
37a8b00
to
99a1fbb
Compare
Yyeah, the thing that peeved me most was the "unnecessary" second sorting pass, but if that is tolerable, so be it. Done. |
99a1fbb
to
b93a101
Compare
Rebased after minor conflict. Would be nice to have sooner than later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with some suggestions
b93a101
to
fbc584d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation looks ok.
Thanks! |
Should mitigate #84796 to an extent, and perhaps supersedes #84939?
The name is pretty self-explanatory.
It uses the warning color. This is used pretty consistently for other "inheritance"-related concepts in the editor, so I think it makes sense.
I was also asked for a bit of padding between overridden and normal properties, although... I still don't like the way it looks, but hey, it works.