Add "missing description" tag to constant & enum documentation #87259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for reviving this :) You missed this part of the requested changes: #85836 (comment) |
|
I thought I did? It's included in both BASE_STRINGS and after godotengine/godot-editor-l10n#14 there too Edit: OH THE ENUMS |
Revives godotengine#85836 Co-Authored-By: krysperz2 <106302189+krysperz2@users.noreply.github.com>
Mickeon
force-pushed
the
documentation-missing-constant-description
branch
from
efbe39a
to
0b02b95
Compare
|
Should be good now, I should make another PR for https://github.com/godotengine/godot-editor-l10n |
Mickeon
added a commit
to Mickeon/godot-editor-l10n
that referenced
this pull request
Jan 16, 2024
Related to godotengine#14 Required for godotengine/godot#87259
Mickeon
changed the title
akien-mga
approved these changes
Jan 16, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revives #85836 with the requested changes.