Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash in GLTFBufferView::load_buffer_view_data #87306

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Fix crash in GLTFBufferView::load_buffer_view_data #87306

merged 1 commit into from
Jan 18, 2024

Conversation

aaronfranke
Copy link
Member

Fixes #87304

@aaronfranke aaronfranke requested a review from a team as a code owner January 17, 2024 17:37
@AThousandShips AThousandShips added this to the 4.3 milestone Jan 17, 2024
@YuriSizov
Copy link
Contributor

YuriSizov commented Jan 17, 2024 •
edited
Loading

Could you please rebase on the current master? We had an issue with macOS builds which failed your CI.

@aaronfranke aaronfranke force-pushed the fix-gltf-buf-view-crash branch from 94ac093 to dc32506 Compare January 18, 2024 02:57
@akien-mga akien-mga changed the title Fix crash in GLTFBufferView::load_buffer_view_data Fix crash in GLTFBufferView::load_buffer_view_data Jan 18, 2024
@akien-mga akien-mga merged commit 29116a8 into godotengine:master Jan 18, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@aaronfranke aaronfranke deleted the fix-gltf-buf-view-crash branch January 18, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuriSizov YuriSizov YuriSizov approved these changes

@fire fire fire approved these changes

Assignees
No one assigned
Labels
bug crash topic:import
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Executing GLTFBufferView.load_buffer_view_data function crashes Godot
5 participants
@aaronfranke @YuriSizov @akien-mga @fire @AThousandShips