Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Direct3D 12: Make format feature check more defensive #87570

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Direct3D 12: Make format feature check more defensive #87570

merged 1 commit into from
Feb 12, 2024

Conversation

RandomShaper
Copy link
Member

Fixes #87529.

@RandomShaper RandomShaper added this to the 4.3 milestone Jan 25, 2024
@RandomShaper RandomShaper mentioned this pull request Jan 25, 2024
Closed
clayjohn
clayjohn approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@clayjohn clayjohn added the bug label Feb 9, 2024
@akien-mga akien-mga merged commit b8b0eea into godotengine:master Feb 12, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@RandomShaper RandomShaper deleted the d3d12_defensive branch February 12, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
bug enhancement topic:rendering
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

CheckFeatureSupport on d3d12 requests DXGI_FORMAT_UNKNOWN instead of R8G8B8A8_UNORM
3 participants
@RandomShaper @akien-mga @clayjohn