Fix crash when importing a GLTF file with a skeleton as the root #87933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronfranke
added
the
cherrypick:4.2
fire
approved these changes
Feb 4, 2024
|
Thanks! |
|
Cherry-picked for 4.2.2. |
akien-mga
removed
the
cherrypick:4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an edge case, but I ran into a situation where the root node of an imported GLTF scene was trying to be generated as a skeleton. This is crashing in the current master. This PR fixes it, now the skeleton will check if there is no root node and if so it will make itself the root node.
Note: The
GLTFDocument::_process_mesh_instancesfunction used to have aNode *p_scene_rootparameter, but it was not used before. In #80272 I removed it. This was not quite the right fix, it should've been used, not removed.