Fix new region select with selection when over geometry

[ryevdokimov]

Fixes: #87949 Fixes #85736

You should be able to region select with the select tool even if you already have a node selected. All other tools already have the default behavior of remotely manipulating their respective gizmo when a node is selected.

Before:

2024-02-03.23-23-48.mp4

After:

2024-02-04.10-32-35.mp4

[KoBeWi]

This breaks selected node dragging:

qVmpxJZhHV.mp4

Dragging should still move a node when the clicked node is part of the current selection.

[ryevdokimov]

Good catch. Working on it...

[ryevdokimov]

Should be fixed now. Had to add code to check whether or not the node(s) trying to be dragged are the ones that are selected.

[ryevdokimov]

Suggestions applied and tested. Thanks for the help.

[Cammymoop]

It seems that both this approach and the one in #85740 could be desirable, probably due to the select mode tool wearing too many hats. I would prefer having the old functionality from before 3.5 restored (selecting and moving a node with a single click) but I could see myself using this style too.

Either way it looks like there's conflicting expectations on how the select tool should work in this instance, aside from the agreement that the current behavior is a bug.

[akien-mga]

Thanks!

@Cammymoop This might warrant opening a proposal to discuss what should be the desired behavior, or whether it needs to be made configurable. If the behavior changed in 3.5 / 4.0 and most users are now familiar with the current behavior as being the intended one, changing it back would likely be a problem for more users than the 3.5 / 4.0 change was.