Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inverted link in docs #87951

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Conversation

AThousandShips
Copy link
Member

Title and url were swapped

Title and url were swapped
@AThousandShips AThousandShips added bug documentation cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Feb 4, 2024
@AThousandShips AThousandShips added this to the 4.3 milestone Feb 4, 2024
@AThousandShips AThousandShips requested a review from a team as a code owner February 4, 2024 17:33
Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not want to know how long this has been there

@ryevdokimov
Copy link
Contributor

ryevdokimov commented Feb 4, 2024

Regex will find more instances of these:

Edit: Apparently, I need to wear glasses.

image

@AThousandShips
Copy link
Member Author

AThousandShips commented Feb 4, 2024

Oh missed the second, will add, searched for it but it was missed

Edit: I did search correctly, as I thought, you've got the second case backwards, it's how it should be (the first one is the one I fixed)

@ryevdokimov
Copy link
Contributor

ryevdokimov commented Feb 4, 2024

Oh I'm an idiot. Hah ignore me.

Edit: Yes this is the only instance.

image

@Mickeon
Copy link
Contributor

Mickeon commented Feb 4, 2024

Thank you for the assistance @ryevdokimov

@ryevdokimov
Copy link
Contributor

Mostly assisted myself in making a fool of myself, but always glad I can help 😂

@akien-mga akien-mga merged commit 01fd96e into godotengine:master Feb 5, 2024
16 checks passed
@AThousandShips AThousandShips deleted the doc_link_fix branch February 5, 2024 14:00
@akien-mga
Copy link
Member

Thanks!

@AThousandShips
Copy link
Member Author

Thank you!

@akien-mga
Copy link
Member

Cherry-picked for 4.2.2.
Cherry-picked for 4.1.4.

@akien-mga akien-mga removed cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants