-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Import] Add "skip file" import option to skip (and exclude from export) importable formats, auto set it for the images used by bitmap font. #87972
Conversation
editor/import_dock.cpp
Outdated
@@ -153,7 +158,11 @@ void ImportDock::_add_keep_import_option(const String &p_importer_name) { | |||
import_as->add_separator(); | |||
import_as->add_item(TTR("Keep File (No Import)")); | |||
import_as->set_item_metadata(-1, "keep"); | |||
import_as->add_item(TTR("Skip File (No Import)")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be:
import_as->add_item(TTR("Skip File (No Import)")); | |
import_as->add_item(TTR("Skip File (No Export)")); |
?
Or "No Import nor Export" but it starts being quite lengthy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if No Import
part is necessary, it's not adding any information. Maybe Keep File (exported as is)
and Skip File (not exported)
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed options to: Keep File (exported as is)
and Skip File (not exported)
.
Also added some doc notes: godotengine/godot-docs#9089
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me, the added "Skip File" option seems potentially useful in other cases (e.g. source .blend
files when you already have a .glb
for the same scene).
I see we're lacking documentation about the existing "Keep File", would be good to add details about both options in https://docs.godotengine.org/en/latest/tutorials/assets_pipeline/import_process.html#changing-import-resource-type
oh yeah please |
…rt) importable formats, auto set it for the images used by bitmap font.
Thanks! |
As mentioned in #87971 and #82254, bitmap fonts use external images, but can't use these images as external resources since in many cases image preprocessing is required.
This PR:
fontdata
).