Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence wayland-scanner check in buildsystem #88028

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Feb 6, 2024

This prevents a wayland-scanner message from appearing every build when wayland=yes is used (the default). The error message when wayland-scanner is still printed as it's not printed by wayland-scanner itself.

wayland-scanner prints its version to stderr instead of stdout (at least in 1.22.0), so stderr needs to be redirected.

This prevents a wayland-scanner message from appearing every build
when `wayland=yes` is used (the default). The error message when
wayland-scanner is still printed as it's not printed by
wayland-scanner itself.
@Calinou Calinou added this to the 4.3 milestone Feb 6, 2024
@Calinou Calinou requested a review from Riteo February 6, 2024 18:50
@Calinou Calinou requested a review from a team as a code owner February 6, 2024 18:50
@adamscott
Copy link
Member

adamscott commented Feb 6, 2024

Are you sure? Here's my wayland-scanner -v result.
image

(i'm using fish)
image

@Calinou
Copy link
Member Author

Calinou commented Feb 6, 2024

Are you sure? Here's my wayland-scanner -v result.

Yes, that's the correct output. You can print to stderr and still have your app exit with code 0. In fact, stderr is often used by apps like FFmpeg to report their progress separately from output messages.

Copy link
Contributor

@Riteo Riteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is a good idea, thanks!

@akien-mga akien-mga merged commit c9c2b12 into godotengine:master Feb 7, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants