Fix NodePath autocompletion to ensure paths are quoted when required #88071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
bug
topic:gdscript
topic:editor
cherrypick:4.2
AThousandShips
approved these changes
Feb 7, 2024
Every component of the path is now checked to be a valid identifier, so that node names that start with a digit always require the full path to be quoted.
Calinou
force-pushed
the
gdscript-nodepath-autocomplete-fix-identifiers
branch
from
19c49fe
to
1238b60
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every component of the path is now checked to be a valid identifier, so that node names that start with a digit always require the full path to be quoted.
Preview