[Windows] Fix windows is_path_invalid, and apply it to directory creation.
#88129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
changed the title
is_path_invalid, and apply it to directory creation.
akien-mga
added
the
cherrypick:4.2
|
Does this also fix #38198 ? Or can it be fixed alongside this with further changes? |
No, it is about platform independent |
|
Makes sense. It can be worth reviewing the issues closed as duplicates of #38198, I think some might actually be solved by this. |
akien-mga
approved these changes
Feb 9, 2024
|
Thanks! |
|
Cherry-picked for 4.2.2. |
akien-mga
removed
the
cherrypick:4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #88120 and applies validity checks to the directory creation.