Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign missing surface data fields in dummy render server #88210

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

TitanNano
Copy link
Contributor

Issue

Doing headless resource imports and subsequent headless project exports causes the texture mapping of gltf meshes to be completely off. After some digging, I discovered that the uv_scale was missing in the imported scene of the gltf files when importing in headless mode.

Solution

MeshStorage::mesh_add_surface does not assign all p_surface_data properties to the new SurfaceData instance.

@fire
Copy link
Member

fire commented Feb 12, 2024

@clayjohn Any ideas what is the resolution on this?

@akien-mga akien-mga merged commit f5ffe70 into godotengine:master Feb 16, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@TitanNano TitanNano deleted the jovan/missing_surface_data branch February 16, 2024 23:44
@clayjohn clayjohn added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release topic:export topic:rendering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants