Fix recursive Tree expand/collapse shortcuts not working #88265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also moves them to use Shift instead of Alt, as was already done for mouse interactions. Shortcuts in Tree were also made non-exact matches so they still work if modifiers are held. This is important for up/down shortcuts, especially once support for selecting with Shift + up/down is implemented.
Calinou
force-pushed
the
tree-fix-recursive-expand-collapse-shortcuts
branch
from
121afaa to
6de0eca
Compare
KoBeWi
approved these changes
Feb 13, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also moves them to use Shift instead of Alt, as was already done for mouse interactions.
Shortcuts in Tree were also made non-exact matches so they still work if modifiers are held. This is important for up/down shortcuts, especially once support for selecting with Shift + up/down is implemented.
Testing project: test_tree_recursive_folding.zip
Preview
tree_item_recursive_keyboard.mp4