Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gradle build errors when the build path contains non-ASCII characters #88304

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Fix gradle build errors when the build path contains non-ASCII characters #88304

merged 1 commit into from
Feb 13, 2024

Conversation

m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented Feb 13, 2024

Fixes #84196

@m4gr3d m4gr3d added this to the 4.3 milestone Feb 13, 2024
@m4gr3d m4gr3d self-assigned this Feb 13, 2024
@m4gr3d m4gr3d requested a review from a team as a code owner February 13, 2024 22:32
@akien-mga akien-mga added bug cherrypick:3.x Considered for cherry-picking into a future 3.x release cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Feb 13, 2024
@akien-mga akien-mga merged commit e5a3fd1 into godotengine:master Feb 13, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@m4gr3d m4gr3d deleted the fix_gradle_build_for_non_ascii_path_main branch February 16, 2024 17:48
@akien-mga
Copy link
Member

Cherry-picked for 4.2.2.
Cherry-picked for 4.1.4.

@akien-mga akien-mga removed cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Mar 9, 2024
@akien-mga
Copy link
Member

Cherry-picked for 3.6.
Cherry-picked for 3.5.4.

@akien-mga akien-mga removed cherrypick:3.x Considered for cherry-picking into a future 3.x release cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release labels Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees

@m4gr3d m4gr3d

Labels
bug platform:android topic:buildsystem
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Gradle daemon process fails starting for user with non-ascii user name on Windows
2 participants
@m4gr3d @akien-mga