-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve look of Donors list in Editor's About #88370
Improve look of Donors list in Editor's About #88370
Conversation
451bd37
to
b28ef5b
Compare
93093dc
to
ab4eb31
Compare
Should be all good now. I gave up trying to lazy-load the About section on NOTIFICATION_READY. It would just crash and the debugger was not helpful in troubleshooting it. |
When you click an item, it loses its hover highlight: godot.windows.editor.dev.x86_64_ezdfAHByTE.mp4 |
Yyyyeah, I thought that the default harsh highlight was a tad excessive so I used an empty StyleBox for it. Either I revert it, or I change the style to use the more "normal" highlighting used when there is a selection but no focus. |
ab4eb31
to
291f85d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks ok.
291f85d
to
b3f9bec
Compare
b3f9bec
to
1a08cba
Compare
Updated the PR to use |
Thanks! |
This PR does a few things to improve how Donors are visualized in the Editor's About section:
get_logo
was removed. It went entirely unused.Note that the Authors page is not (currently) affected.