Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve look of Donors list in Editor's About #88370

Merged

Conversation

Mickeon
Copy link
Contributor

@Mickeon Mickeon commented Feb 15, 2024

This PR does a few things to improve how Donors are visualized in the Editor's About section:

  • Website links are hidden within the donor's name.
    • Donors with associated websites display an icon.
    • Hovering over these donors displays their website if it exists.
    • Double-clicking opens the website on browser.
  • The "And _ anonymous donors" part is grayed out.
  • Most donors are always split in 3 equally-spaced columns regardless of size.
  • Internally, get_logo was removed. It went entirely unused.

Note that the Authors page is not (currently) affected.

@Mickeon Mickeon force-pushed the editor-about-page-websites-squashing branch from 451bd37 to b28ef5b Compare February 15, 2024 20:55
@YeldhamDev YeldhamDev added this to the 4.x milestone Feb 15, 2024
@Mickeon Mickeon force-pushed the editor-about-page-websites-squashing branch 2 times, most recently from 93093dc to ab4eb31 Compare February 16, 2024 15:36
@Mickeon Mickeon marked this pull request as ready for review February 16, 2024 15:36
@Mickeon
Copy link
Contributor Author

Mickeon commented Feb 16, 2024

Should be all good now. I gave up trying to lazy-load the About section on NOTIFICATION_READY. It would just crash and the debugger was not helpful in troubleshooting it.

@Mickeon Mickeon requested review from Calinou and KoBeWi February 17, 2024 09:50
@KoBeWi
Copy link
Member

KoBeWi commented Feb 17, 2024

When you click an item, it loses its hover highlight:

godot.windows.editor.dev.x86_64_ezdfAHByTE.mp4

@Mickeon
Copy link
Contributor Author

Mickeon commented Feb 17, 2024

Yyyyeah, I thought that the default harsh highlight was a tad excessive so I used an empty StyleBox for it. Either I revert it, or I change the style to use the more "normal" highlighting used when there is a selection but no focus.
I think selected_focus is the culprit?

editor/editor_about.h Outdated Show resolved Hide resolved
editor/editor_about.cpp Outdated Show resolved Hide resolved
editor/editor_about.cpp Outdated Show resolved Hide resolved
editor/editor_about.cpp Outdated Show resolved Hide resolved
editor/editor_about.cpp Outdated Show resolved Hide resolved
editor/editor_about.cpp Outdated Show resolved Hide resolved
@Mickeon Mickeon force-pushed the editor-about-page-websites-squashing branch from ab4eb31 to 291f85d Compare February 17, 2024 18:26
Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks ok.

@Mickeon Mickeon force-pushed the editor-about-page-websites-squashing branch from 291f85d to b3f9bec Compare February 17, 2024 20:07
@Mickeon Mickeon force-pushed the editor-about-page-websites-squashing branch from b3f9bec to 1a08cba Compare February 17, 2024 22:43
@Mickeon
Copy link
Contributor Author

Mickeon commented Feb 17, 2024

Updated the PR to use font_disabled_color instead of hardcoded Color(1, 1, 1, 0.5) for the ExternalLink icons.

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Feb 17, 2024
@akien-mga akien-mga merged commit 0164e49 into godotengine:master Feb 19, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants