Remove NavigationServerDummy warnings #88375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scony
approved these changes
Feb 15, 2024
akien-mga
reviewed
Feb 15, 2024
smix8
force-pushed
the
navserver_dummy_warnings
branch
from
a66968e
to
bde6bae
Compare
Removes NavigationServerDummy warnings.
smix8
force-pushed
the
navserver_dummy_warnings
branch
from
bde6bae
to
a670376
Compare
akien-mga
approved these changes
Apr 6, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes NavigationServerDummy warnings.
Godot does not spam dummy warnings for anything else in the engine that uses a dummy implementation when certain features are disabled. The console is quiet with a Godot minimalist build while the NavigationServer is all spammy about it.
You only get those warnings and dummies when you use a build with disabled navigation module which you need to create deliberately so it is not as if you disabled them by accident. Those dummy warnings have no real informational value as it really only matters to know when the dummy fails to load as an error.