Fix unshaded debug draw mode for LightmapGI

[oxi-dev0]

Fixes #88341

[jsjtxietian]

See https://docs.godotengine.org/en/stable/contributing/workflow/pr_workflow.html#modifying-a-pull-request , "we will prefer a single commit in a given PR (unless there's a good reason to keep the changes separate)" , don't forget to squash your pr 😄

[Calinou]

I just realized objects with the Dynamic GI mode have the same issue in Forward+ and Mobile. This is in master, and it also occurs with this PR:

Object on the left uses Disabled GI mode, object on the right uses the Dynamic GI mode.

[Calinou]

Tested locally, it works as expected in all rendering methods.

However, when using Forward+ or Mobile, dynamic objects are still shaded as seen in the comment above. Could you look into resolving this as well? Thanks in advance 🙂

[oxi-dev0]

yes i will look into fixing dynamic objects, and squash the pr 😁

[oxi-dev0]

Looking at that dynamic bug, it fixes itself if you bake the lightmap while the mesh is dynamic. It just seems like a general lightmapper issue

[Calinou]

Looking at that dynamic bug, it fixes itself if you bake the lightmap while the mesh is dynamic. It just seems like a general lightmapper issue

This is due to #77167. The object with Dynamic GI mode is considered to use the Disabled GI mode until it's moved after baking lightmaps. That bug ends up hiding this particular issue, but once it's resolved, the object with Dynamic GI won't be unshaded anymore after baking lightmaps.

[oxi-dev0]

Right ok, I'll take a look at it anyway

[Calinou]

This PR now seems to work correctly for dynamic objects with all rendering methods. I'd appreciate a second look just in case as I don't know if it's a fluke with my testing project.

[akien-mga]

@oxi-dev0 Could you rebase to resolve the merge conflicts?

[oxi-dev0]

Thanks for the help!

[akien-mga]

Thanks! And congrats for your first merged Godot contribution 🎉