Allow VisibleOnScreenNotifier2D/3D to have empty enable_node_path
#88403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The property description needs to be updated. |
Mickeon
force-pushed
the
VisibleOnScreenNotifier-is-differently-abled
branch
from
70cd088
to
7b0f46a
Compare
|
I keep confusing VisibleOnScreenNotifier with VisibleOnScreenEnabler but still. It could be rewritten outright but a simple change should be good enough. |
Mickeon
force-pushed
the
VisibleOnScreenNotifier-is-differently-abled
branch
from
7b0f46a
to
7dabe6a
Compare
|
Pushed something else to prevent fetching the node on an empty path outright. |
Mickeon
changed the title
enable_node_path without errorsenable_node_path
Mickeon
force-pushed
the
VisibleOnScreenNotifier-is-differently-abled
branch
from
7dabe6a
to
445b1e9
Compare
|
All good now I think. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this closes godotengine/godot-proposals#9069, technically?
I was considering making this a draft until I was confident in adding a configuration warning due to #88379. But... Technically this PR works just fine standalone, doesn't it?