Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow VisibleOnScreenNotifier2D/3D to have empty enable_node_path #88403

Conversation

Mickeon
Copy link
Contributor

@Mickeon Mickeon commented Feb 16, 2024

I believe this closes godotengine/godot-proposals#9069, technically?

I was considering making this a draft until I was confident in adding a configuration warning due to #88379. But... Technically this PR works just fine standalone, doesn't it?

@Mickeon Mickeon requested review from a team as code owners February 16, 2024 14:58
@Mickeon Mickeon added this to the 4.3 milestone Feb 16, 2024
@KoBeWi
Copy link
Member

KoBeWi commented Feb 16, 2024

The property description needs to be updated.

@Mickeon Mickeon force-pushed the VisibleOnScreenNotifier-is-differently-abled branch from 70cd088 to 7b0f46a Compare February 16, 2024 15:57
@Mickeon Mickeon requested a review from a team as a code owner February 16, 2024 15:57
@Mickeon
Copy link
Contributor Author

Mickeon commented Feb 16, 2024

I keep confusing VisibleOnScreenNotifier with VisibleOnScreenEnabler but still. It could be rewritten outright but a simple change should be good enough.

@Mickeon Mickeon force-pushed the VisibleOnScreenNotifier-is-differently-abled branch from 7b0f46a to 7dabe6a Compare February 16, 2024 16:09
@Mickeon
Copy link
Contributor Author

Mickeon commented Feb 16, 2024

Pushed something else to prevent fetching the node on an empty path outright.

@Mickeon Mickeon changed the title Allow VisibleOnScreenNotifier2D/3D to have no enable_node_path without errors Allow VisibleOnScreenNotifier2D/3D to have empty enable_node_path Feb 16, 2024
@Mickeon Mickeon force-pushed the VisibleOnScreenNotifier-is-differently-abled branch from 7dabe6a to 445b1e9 Compare February 16, 2024 16:34
@Mickeon
Copy link
Contributor Author

Mickeon commented Feb 16, 2024

All good now I think.

Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akien-mga akien-mga merged commit cde4544 into godotengine:master Feb 16, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@Mickeon Mickeon deleted the VisibleOnScreenNotifier-is-differently-abled branch February 16, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There should be a way to disable a VisibleOnScreenEnabler
4 participants