Remember frames when selecting SpriteFrame frames

[LeulMulugeta]

this will stop resting the options for "Select Frames" window on reopening an image or a subsequent opening of the same size image. this will be useful in the cases of :

• working with a large sprite sheet containing multiple animations
• and when each characters in a project have the same sprite sheet size.

---

• After looking for a proposal i also realize there is an alternative PR already which hasn't been updated for a while Improve usability of the SpriteFramesEditor #80448
• This seems simpler .. but i am also a noob so am probably missing something.. so feel free to close this PR
• Partially implements: "Select Frames" window should remember previous settings godot-proposals#7021

[AThousandShips]

This doesn't really fully resolve that proposal IMO, this won't work if the editor is restarted for example

Also what happens if you use a texture that's very different in size or shape?

See also (to make it clear this is an alternative to another PR):

• Improve usability of the SpriteFramesEditor #80448

[AThousandShips]

Quickly testing this and it makes the editor essentially unusable when changing to a new texture, if you take a large texture first, where each frame is, lets say, 256x256, and then pick a texture that's 128x128, then you will get a single, 128x128 frame covering the whole image

If you then change back to the original texture it will give you a single 128x128 frame at the top left

This needs to detect other changes, and retain specific details, like the other PR did

[LeulMulugeta]

ok.. i will make considerations for changes in texture size

[AThousandShips]

As already seen in the other PR, and from my own experience implementing this, this isn't a trivial simple change to make, so I think you will have to rewrite this quite from the ground up

[LeulMulugeta]

Sorry for the noise .. i was learning git :/

Resolved

[AThousandShips]

While these changes are an improvement they only work when the new texture is exactly the same size, which helps only a little bit, the proper solution would be to retain the mode, there's an edit mode used which selects if you are editing the number of sections, or the size of each, this could be used

This is still an improvement but I don't know if it alone is sufficient as a PR, but again the proper solution is complex

[KoBeWi]

Looks fine implementation-wise, but can't say how much useful is it in the current form and how well it would integrate with the full solution.

[akien-mga]

Could you squash the commits, and amend the resulting commit to give it a clearer title (like the PR)? See PR workflow for instructions.

[kleonc]

As already mentioned by others this is a very simple implementation which doesn't solve the issue in general case. But it does improve a basic use case when subsequently creating separate animations from the same-layout spritesheets. For other use cases the usage should be as annoying as before. 🙃

So it's fine to merge, a better solution can be implemented later.

[akien-mga]

Thanks! And congrats for your first merged Godot contribution 🎉