Fix function description for Font.get_char_size()
#88444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed description implying you can pass a second char in order to account for kerning
AThousandShips
added
bug
documentation
cherrypick:4.1
Mickeon
approved these changes
Feb 17, 2024
| @@ -136,7 +136,7 @@ | |||
| <param index="0" name="char" type="int" /> | |||
| <param index="1" name="font_size" type="int" /> | |||
| <description> | |||
| Returns the size of a character, optionally taking kerning into account if the next character is provided. | |||
| Returns the size of a character. Does not take kerning into account. | |||
There was a problem hiding this comment.
Not sure if mentioning kerning is even necessary anymore. I don't know how any reader would assume kerning is accounted for.
Does it hurt though? No...?
There was a problem hiding this comment.
Fair point, I don't mind either way
There was a problem hiding this comment.
I think it's fine to be explicit.
akien-mga
changed the title
Font.get_char_size()
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
|
Cherry-picked for 4.2.2. |
akien-mga
removed
cherrypick:4.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugsquad edit: closes #88348
Removed description implying you can pass a second char in order to account for kerning