Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reversed custom AABB check when recalculating multimesh AABBs #88506

Merged
merged 1 commit into from
Feb 18, 2024

Conversation

puchik
Copy link
Contributor

@puchik puchik commented Feb 18, 2024

When deciding whether to recalculate AABBs, the check for whether a custom AABB exists is reversed. This PR corrects the check and fixes AABB recalculation problems.

Fixes #88458

@puchik puchik requested a review from a team as a code owner February 18, 2024 17:02
@AThousandShips AThousandShips changed the title Fixed reversed custom AABB check when recalculating multimesh AABBs Fix reversed custom AABB check when recalculating multimesh AABBs Feb 18, 2024
@AThousandShips AThousandShips added this to the 4.3 milestone Feb 18, 2024
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! We also need to reverse the conditions in multimesh_set_buffer too.

@puchik puchik force-pushed the multimesh-aabb-cull-fix branch from b2331ff to 533eab8 Compare February 18, 2024 20:07
@puchik
Copy link
Contributor Author

puchik commented Feb 18, 2024

Pushed!

@akien-mga akien-mga merged commit 8cf1cfd into godotengine:master Feb 18, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All instances of MultiMeshInstance2D are culled if the origin goes off screen
5 participants