Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the crash handler if execinfo=no scons option is set #88520

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

LinuxUserGD
Copy link
Contributor

@LinuxUserGD LinuxUserGD commented Feb 18, 2024

Because the crash handler is not enabled in template_release build mode, libexecinfo is not always required on non-glibc systems.

On Gentoo Linux, libexecinfo is not packaged and therefore scons is patched to disable execinfo=yes by default:
https://gitweb.gentoo.org/repo/gentoo.git/tree/dev-games/godot/files/godot-4.0_rc2-musl.patch

The PR changes the default value of the Scons option execinfo to None so libexecinfo will not be implicitely linked if the Scons option execinfo=no is specified.

See #57193

@LinuxUserGD LinuxUserGD requested a review from a team as a code owner February 18, 2024 22:14
@Calinou
Copy link
Member

Calinou commented Feb 18, 2024

Because the crash handler is not enabled in template_release build mode

We should really look into changing that, as this behavior is inconsistent depending on the platform and users ought to be able to investigate crashes with release export templates too. Otherwise, reporting bugs becomes much harder for players of your game. #61906 is the first step towards improving this, but it's also designed to work in exported projects.

@Riteo
Copy link
Contributor

Riteo commented Mar 5, 2024

So, I do agree on having the crash handler in the release template too but, in the meanwhile, wouldn't it make sense to consider it still? The wording above by @Calinou seems to block it, but I might be mistaken.

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Mar 5, 2024
@akien-mga akien-mga changed the title Disable the crash handler if execinfo=no scons option is set Disable the crash handler if execinfo=no scons option is set Mar 5, 2024
@akien-mga akien-mga merged commit 2ecf0eb into godotengine:master Mar 5, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@Riteo
Copy link
Contributor

Riteo commented Mar 5, 2024

Oops, forgot to send the review, my bad :P

Just saying that from my part it looks fine! I always like improvements for "non-mainstream" setups!

@LinuxUserGD LinuxUserGD deleted the execinfo branch March 6, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants