Add separate program case for Godot Resources #88523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mickeon
approved these changes
Feb 19, 2024
|
Should the same logic be applied to |
|
Not sure where this is handled but in 4.2 this seems to already be the case. |
|
tscn uses default program, and you probably have it configured to VS Code. I can add an explicit case. |
KoBeWi
force-pushed
the
open_text_as_text
branch
from
65a933b
to
a08fddd
Compare
|
Should binary |
|
Maybe, but how? Should they fallback to the default program? |
|
Whatever program one would use it'd still display as gibberish, with maybe a few words somewhere in there, so maybe yes. |
KoBeWi
force-pushed
the
open_text_as_text
branch
from
a08fddd
to
bb46198
Compare
KoBeWi
changed the title
tres files
akien-mga
approved these changes
Feb 20, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open in External program option in FileSystem Dock currently checks only for file types, which might yield some wrong results in case of tres files (like opening AudioStreamGenerator in audio editor). Since they are always text, the dock will now always open them with the external text editor, or a default program for tres files. The PR also includes some small refactor.