OS_LinuxBSD: Add missing RenderServer include for get_video_adapter_driver_info
#88525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinuxUserGD
force-pushed
the
RenderingServer
branch
from
a3fc31d to
b4da3d0
Compare
akien-mga
changed the title
get_video_adapter_driver_info compilation if RenderingServer is undefined
|
That doesn't seem to be the right fix. RenderingServer is always compiled, regardless of options. The problem here is simply that it's not properly included in this file, and only happens to be usually there as a transitive include brought by another one (likely the X11 and Wayland display servers). So the proper fix is to include |
LinuxUserGD
force-pushed
the
RenderingServer
branch
from
b4da3d0 to
6307ceb
Compare
Ok, updated the PR accordingly (which compiles with the build options) |
akien-mga
changed the title
get_video_adapter_driver_info compilation if RenderingServer is undefinedget_video_adapter_driver_info
akien-mga
changed the title
get_video_adapter_driver_infoget_video_adapter_driver_info
akien-mga
approved these changes
Feb 19, 2024
akien-mga
added
the
cherrypick:4.2
|
Thanks! |
akien-mga
added
the
cherrypick:4.1
|
Cherry-picked for 4.2.2. |
akien-mga
removed
cherrypick:4.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #88524