Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Rider.PathLocator nuget version, which provides a fix for detecting Rider installations #88544

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

van800
Copy link
Contributor

@van800 van800 commented Feb 19, 2024

Corresponding change in the RiderPathLocator sources JetBrains/resharper-unity@cc2a0e8

@van800 van800 requested a review from a team as a code owner February 19, 2024 11:23
@raulsntos raulsntos added this to the 4.3 milestone Feb 19, 2024
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm it fixes the issue. Thanks!

@akien-mga
Copy link
Member

Could you amend the commit message to have the title state what the bug is that's being fixed? E.g. copy the title of this PR. We don't really know what the RIDER bug number corresponds to in Godot ;)

@akien-mga akien-mga changed the title Bump Rider.PathLocator nuget version, which provides a fix for detecting Rider installations Bump Rider.PathLocator nuget version, which provides a fix for detecting Rider installations Feb 19, 2024
@van800 van800 force-pushed the van800/rider-path-locator branch from 531da91 to 703c34a Compare February 19, 2024 18:04
@van800
Copy link
Contributor Author

van800 commented Feb 19, 2024

Could you amend the commit message to have the title state what the bug is that's being fixed? E.g. copy the title of this PR. We don't really know what the RIDER bug number corresponds to in Godot ;)

Done!

@akien-mga akien-mga merged commit 5458727 into godotengine:master Feb 20, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Feb 25, 2024
@akien-mga
Copy link
Member

Cherry-picked for 4.2.2.

@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants